Skip to content

Use clearer variable name#290

Merged
morskyjezek merged 4 commits into
LibraryCarpentry:mainfrom
bkmgit:patch-5
Nov 24, 2025
Merged

Use clearer variable name#290
morskyjezek merged 4 commits into
LibraryCarpentry:mainfrom
bkmgit:patch-5

Conversation

@bkmgit
Copy link
Copy Markdown
Contributor

@bkmgit bkmgit commented Nov 18, 2025

If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.

NA

Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.

Use filename instead of file as the iteration varibale name in the loops section

If any relevant discussions have taken place elsewhere, please provide links to these.

#259 (comment)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 18, 2025 •
edited
Loading

🆗 Pre-flight checks passed 😃

This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits.

Results of any additional workflows will appear here when they are done.

github-actions Bot pushed a commit that referenced this pull request Nov 18, 2025
@actions-user
differences for PR #290
f192448
@bkmgit bkmgit mentioned this pull request Nov 18, 2025
Merged
bkmgit
bkmgit commented Nov 21, 2025
View reviewed changes
Comment thread episodes/files/my_first_bash_script.sh Outdated
github-actions Bot pushed a commit that referenced this pull request Nov 21, 2025
@actions-user
differences for PR #290
d25046e
@morskyjezek
Copy link
Copy Markdown
Contributor

morskyjezek commented Nov 24, 2025

The variable filename also conforms to the example earlier in the lesson.

@morskyjezek morskyjezek merged commit c2c2fb4 into LibraryCarpentry:main Nov 24, 2025
3 checks passed
github-actions Bot pushed a commit that referenced this pull request Nov 24, 2025
@actions-user
markdown source builds
ce69a15 
Auto-generated via `{sandpaper}`
Source  : c2c2fb4
Branch  : main
Author  : Jesse Johnston <morskyjezek@gmail.com>
Time    : 2025-11-24 12:17:19 +0000
Message : Merge pull request #290 from bkmgit/patch-5

Use clearer variable name
github-actions Bot pushed a commit that referenced this pull request Nov 24, 2025
@actions-user
site deploy
9b96d60 
Auto-generated via `{sandpaper}`
Source  : ce69a15
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-11-24 12:18:26 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c2c2fb4
Branch  : main
Author  : Jesse Johnston <morskyjezek@gmail.com>
Time    : 2025-11-24 12:17:19 +0000
Message : Merge pull request #290 from bkmgit/patch-5

Use clearer variable name
github-actions Bot pushed a commit that referenced this pull request Nov 25, 2025
@actions-user
site deploy
e038a93 
Auto-generated via `{sandpaper}`
Source  : ce69a15
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-11-24 12:18:26 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c2c2fb4
Branch  : main
Author  : Jesse Johnston <morskyjezek@gmail.com>
Time    : 2025-11-24 12:17:19 +0000
Message : Merge pull request #290 from bkmgit/patch-5

Use clearer variable name
@bkmgit bkmgit deleted the patch-5 branch November 25, 2025 10:25
github-actions Bot pushed a commit that referenced this pull request Dec 2, 2025
@actions-user
site deploy
d52efca 
Auto-generated via `{sandpaper}`
Source  : ce69a15
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-11-24 12:18:26 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c2c2fb4
Branch  : main
Author  : Jesse Johnston <morskyjezek@gmail.com>
Time    : 2025-11-24 12:17:19 +0000
Message : Merge pull request #290 from bkmgit/patch-5

Use clearer variable name
github-actions Bot pushed a commit that referenced this pull request Dec 9, 2025
@actions-user
site deploy
3e49dfc 
Auto-generated via `{sandpaper}`
Source  : ce69a15
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-11-24 12:18:26 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c2c2fb4
Branch  : main
Author  : Jesse Johnston <morskyjezek@gmail.com>
Time    : 2025-11-24 12:17:19 +0000
Message : Merge pull request #290 from bkmgit/patch-5

Use clearer variable name
github-actions Bot pushed a commit that referenced this pull request Dec 16, 2025
@actions-user
site deploy
557eba5 
Auto-generated via `{sandpaper}`
Source  : ce69a15
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-11-24 12:18:26 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c2c2fb4
Branch  : main
Author  : Jesse Johnston <morskyjezek@gmail.com>
Time    : 2025-11-24 12:17:19 +0000
Message : Merge pull request #290 from bkmgit/patch-5

Use clearer variable name
github-actions Bot pushed a commit that referenced this pull request Dec 23, 2025
@actions-user
site deploy
42cb442 
Auto-generated via `{sandpaper}`
Source  : ce69a15
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-11-24 12:18:26 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c2c2fb4
Branch  : main
Author  : Jesse Johnston <morskyjezek@gmail.com>
Time    : 2025-11-24 12:17:19 +0000
Message : Merge pull request #290 from bkmgit/patch-5

Use clearer variable name
github-actions Bot pushed a commit that referenced this pull request Dec 30, 2025
@actions-user
site deploy
dfe10a5 
Auto-generated via `{sandpaper}`
Source  : ce69a15
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-11-24 12:18:26 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c2c2fb4
Branch  : main
Author  : Jesse Johnston <morskyjezek@gmail.com>
Time    : 2025-11-24 12:17:19 +0000
Message : Merge pull request #290 from bkmgit/patch-5

Use clearer variable name
github-actions Bot pushed a commit that referenced this pull request Jan 6, 2026
@actions-user
site deploy
239b3b9 
Auto-generated via `{sandpaper}`
Source  : ce69a15
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-11-24 12:18:26 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c2c2fb4
Branch  : main
Author  : Jesse Johnston <morskyjezek@gmail.com>
Time    : 2025-11-24 12:17:19 +0000
Message : Merge pull request #290 from bkmgit/patch-5

Use clearer variable name
github-actions Bot pushed a commit that referenced this pull request Jan 20, 2026
@actions-user
site deploy
b5a8844 
Auto-generated via `{sandpaper}`
Source  : ce69a15
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-11-24 12:18:26 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c2c2fb4
Branch  : main
Author  : Jesse Johnston <morskyjezek@gmail.com>
Time    : 2025-11-24 12:17:19 +0000
Message : Merge pull request #290 from bkmgit/patch-5

Use clearer variable name
github-actions Bot pushed a commit that referenced this pull request Jan 27, 2026
@actions-user
site deploy
9c1c256 
Auto-generated via `{sandpaper}`
Source  : ce69a15
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-11-24 12:18:26 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c2c2fb4
Branch  : main
Author  : Jesse Johnston <morskyjezek@gmail.com>
Time    : 2025-11-24 12:17:19 +0000
Message : Merge pull request #290 from bkmgit/patch-5

Use clearer variable name
github-actions Bot pushed a commit that referenced this pull request Feb 3, 2026
@actions-user
site deploy
dae1b6e 
Auto-generated via `{sandpaper}`
Source  : ce69a15
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-11-24 12:18:26 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c2c2fb4
Branch  : main
Author  : Jesse Johnston <morskyjezek@gmail.com>
Time    : 2025-11-24 12:17:19 +0000
Message : Merge pull request #290 from bkmgit/patch-5

Use clearer variable name
github-actions Bot pushed a commit that referenced this pull request Feb 3, 2026
@actions-user
site deploy
adb2afb 
Auto-generated via `{sandpaper}`
Source  : ce69a15
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-11-24 12:18:26 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c2c2fb4
Branch  : main
Author  : Jesse Johnston <morskyjezek@gmail.com>
Time    : 2025-11-24 12:17:19 +0000
Message : Merge pull request #290 from bkmgit/patch-5

Use clearer variable name
github-actions Bot pushed a commit that referenced this pull request Feb 3, 2026
@actions-user
site deploy
e59d6f6 
Auto-generated via `{sandpaper}`
Source  : ce69a15
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-11-24 12:18:26 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c2c2fb4
Branch  : main
Author  : Jesse Johnston <morskyjezek@gmail.com>
Time    : 2025-11-24 12:17:19 +0000
Message : Merge pull request #290 from bkmgit/patch-5

Use clearer variable name
github-actions Bot pushed a commit that referenced this pull request Feb 3, 2026
@actions-user
site deploy
f652fbc 
Auto-generated via `{sandpaper}`
Source  : ce69a15
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-11-24 12:18:26 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c2c2fb4
Branch  : main
Author  : Jesse Johnston <morskyjezek@gmail.com>
Time    : 2025-11-24 12:17:19 +0000
Message : Merge pull request #290 from bkmgit/patch-5

Use clearer variable name
github-actions Bot pushed a commit that referenced this pull request Feb 3, 2026
@actions-user
site deploy
c9813f9 
Auto-generated via `{sandpaper}`
Source  : ce69a15
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-11-24 12:18:26 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c2c2fb4
Branch  : main
Author  : Jesse Johnston <morskyjezek@gmail.com>
Time    : 2025-11-24 12:17:19 +0000
Message : Merge pull request #290 from bkmgit/patch-5

Use clearer variable name
github-actions Bot pushed a commit that referenced this pull request Feb 3, 2026
@actions-user
site deploy
479d576 
Auto-generated via `{sandpaper}`
Source  : ce69a15
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-11-24 12:18:26 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c2c2fb4
Branch  : main
Author  : Jesse Johnston <morskyjezek@gmail.com>
Time    : 2025-11-24 12:17:19 +0000
Message : Merge pull request #290 from bkmgit/patch-5

Use clearer variable name
github-actions Bot pushed a commit that referenced this pull request Feb 3, 2026
@actions-user
site deploy
a341e61 
Auto-generated via `{sandpaper}`
Source  : ce69a15
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-11-24 12:18:26 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c2c2fb4
Branch  : main
Author  : Jesse Johnston <morskyjezek@gmail.com>
Time    : 2025-11-24 12:17:19 +0000
Message : Merge pull request #290 from bkmgit/patch-5

Use clearer variable name
github-actions Bot pushed a commit that referenced this pull request Feb 8, 2026
@actions-user
site deploy
e9eba91 
Auto-generated via `{sandpaper}`
Source  : ce69a15
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-11-24 12:18:26 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c2c2fb4
Branch  : main
Author  : Jesse Johnston <morskyjezek@gmail.com>
Time    : 2025-11-24 12:17:19 +0000
Message : Merge pull request #290 from bkmgit/patch-5

Use clearer variable name
github-actions Bot pushed a commit that referenced this pull request Feb 10, 2026
@actions-user
site deploy
f9e1a22 
Auto-generated via `{sandpaper}`
Source  : ce69a15
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-11-24 12:18:26 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c2c2fb4
Branch  : main
Author  : Jesse Johnston <morskyjezek@gmail.com>
Time    : 2025-11-24 12:17:19 +0000
Message : Merge pull request #290 from bkmgit/patch-5

Use clearer variable name
github-actions Bot pushed a commit that referenced this pull request Feb 17, 2026
@actions-user
site deploy
0901783 
Auto-generated via `{sandpaper}`
Source  : ce69a15
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-11-24 12:18:26 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c2c2fb4
Branch  : main
Author  : Jesse Johnston <morskyjezek@gmail.com>
Time    : 2025-11-24 12:17:19 +0000
Message : Merge pull request #290 from bkmgit/patch-5

Use clearer variable name
github-actions Bot pushed a commit that referenced this pull request Feb 24, 2026
@actions-user
site deploy
9bcdd3d 
Auto-generated via `{sandpaper}`
Source  : ce69a15
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-11-24 12:18:26 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c2c2fb4
Branch  : main
Author  : Jesse Johnston <morskyjezek@gmail.com>
Time    : 2025-11-24 12:17:19 +0000
Message : Merge pull request #290 from bkmgit/patch-5

Use clearer variable name
github-actions Bot pushed a commit that referenced this pull request Mar 3, 2026
@actions-user
site deploy
edbea69 
Auto-generated via `{sandpaper}`
Source  : ce69a15
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-11-24 12:18:26 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c2c2fb4
Branch  : main
Author  : Jesse Johnston <morskyjezek@gmail.com>
Time    : 2025-11-24 12:17:19 +0000
Message : Merge pull request #290 from bkmgit/patch-5

Use clearer variable name
github-actions Bot pushed a commit that referenced this pull request Mar 3, 2026
@actions-user
site deploy
59b08a9 
Auto-generated via `{sandpaper}`
Source  : ce69a15
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-11-24 12:18:26 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c2c2fb4
Branch  : main
Author  : Jesse Johnston <morskyjezek@gmail.com>
Time    : 2025-11-24 12:17:19 +0000
Message : Merge pull request #290 from bkmgit/patch-5

Use clearer variable name
github-actions Bot pushed a commit that referenced this pull request Mar 10, 2026
@actions-user
site deploy
63a99a0 
Auto-generated via `{sandpaper}`
Source  : ce69a15
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-11-24 12:18:26 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c2c2fb4
Branch  : main
Author  : Jesse Johnston <morskyjezek@gmail.com>
Time    : 2025-11-24 12:17:19 +0000
Message : Merge pull request #290 from bkmgit/patch-5

Use clearer variable name
github-actions Bot pushed a commit that referenced this pull request Mar 17, 2026
@actions-user
site deploy
ae95b21 
Auto-generated via `{sandpaper}`
Source  : ce69a15
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-11-24 12:18:26 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c2c2fb4
Branch  : main
Author  : Jesse Johnston <morskyjezek@gmail.com>
Time    : 2025-11-24 12:17:19 +0000
Message : Merge pull request #290 from bkmgit/patch-5

Use clearer variable name
github-actions Bot pushed a commit that referenced this pull request Mar 24, 2026
@actions-user
site deploy
39e19b8 
Auto-generated via `{sandpaper}`
Source  : ce69a15
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-11-24 12:18:26 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c2c2fb4
Branch  : main
Author  : Jesse Johnston <morskyjezek@gmail.com>
Time    : 2025-11-24 12:17:19 +0000
Message : Merge pull request #290 from bkmgit/patch-5

Use clearer variable name
github-actions Bot pushed a commit that referenced this pull request Mar 31, 2026
@actions-user
site deploy
b3768ad 
Auto-generated via `{sandpaper}`
Source  : ce69a15
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-11-24 12:18:26 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c2c2fb4
Branch  : main
Author  : Jesse Johnston <morskyjezek@gmail.com>
Time    : 2025-11-24 12:17:19 +0000
Message : Merge pull request #290 from bkmgit/patch-5

Use clearer variable name
github-actions Bot pushed a commit that referenced this pull request Apr 7, 2026
@actions-user
site deploy
0acddd1 
Auto-generated via `{sandpaper}`
Source  : ce69a15
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-11-24 12:18:26 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c2c2fb4
Branch  : main
Author  : Jesse Johnston <morskyjezek@gmail.com>
Time    : 2025-11-24 12:17:19 +0000
Message : Merge pull request #290 from bkmgit/patch-5

Use clearer variable name
github-actions Bot pushed a commit that referenced this pull request Apr 14, 2026
@actions-user
site deploy
a5a6048 
Auto-generated via `{sandpaper}`
Source  : ce69a15
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-11-24 12:18:26 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c2c2fb4
Branch  : main
Author  : Jesse Johnston <morskyjezek@gmail.com>
Time    : 2025-11-24 12:17:19 +0000
Message : Merge pull request #290 from bkmgit/patch-5

Use clearer variable name
github-actions Bot pushed a commit that referenced this pull request Apr 21, 2026
@actions-user
site deploy
a34a73b 
Auto-generated via `{sandpaper}`
Source  : ce69a15
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-11-24 12:18:26 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c2c2fb4
Branch  : main
Author  : Jesse Johnston <morskyjezek@gmail.com>
Time    : 2025-11-24 12:17:19 +0000
Message : Merge pull request #290 from bkmgit/patch-5

Use clearer variable name
github-actions Bot pushed a commit that referenced this pull request Apr 21, 2026
@actions-user
site deploy
f2819d7 
Auto-generated via `{sandpaper}`
Source  : ce69a15
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-11-24 12:18:26 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c2c2fb4
Branch  : main
Author  : Jesse Johnston <morskyjezek@gmail.com>
Time    : 2025-11-24 12:17:19 +0000
Message : Merge pull request #290 from bkmgit/patch-5

Use clearer variable name
github-actions Bot pushed a commit that referenced this pull request Apr 28, 2026
@actions-user
site deploy
ca0be53 
Auto-generated via `{sandpaper}`
Source  : ce69a15
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-11-24 12:18:26 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c2c2fb4
Branch  : main
Author  : Jesse Johnston <morskyjezek@gmail.com>
Time    : 2025-11-24 12:17:19 +0000
Message : Merge pull request #290 from bkmgit/patch-5

Use clearer variable name
github-actions Bot pushed a commit that referenced this pull request May 5, 2026
@actions-user
site deploy
6ac01ac 
Auto-generated via `{sandpaper}`
Source  : ce69a15
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-11-24 12:18:26 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c2c2fb4
Branch  : main
Author  : Jesse Johnston <morskyjezek@gmail.com>
Time    : 2025-11-24 12:17:19 +0000
Message : Merge pull request #290 from bkmgit/patch-5

Use clearer variable name
github-actions Bot pushed a commit that referenced this pull request May 12, 2026
@actions-user
site deploy
0ccccba 
Auto-generated via `{sandpaper}`
Source  : ce69a15
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-11-24 12:18:26 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c2c2fb4
Branch  : main
Author  : Jesse Johnston <morskyjezek@gmail.com>
Time    : 2025-11-24 12:17:19 +0000
Message : Merge pull request #290 from bkmgit/patch-5

Use clearer variable name
github-actions Bot pushed a commit that referenced this pull request May 19, 2026
@actions-user
site deploy
e76daa9 
Auto-generated via `{sandpaper}`
Source  : ce69a15
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-11-24 12:18:26 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c2c2fb4
Branch  : main
Author  : Jesse Johnston <morskyjezek@gmail.com>
Time    : 2025-11-24 12:17:19 +0000
Message : Merge pull request #290 from bkmgit/patch-5

Use clearer variable name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morskyjezek morskyjezek morskyjezek approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bkmgit @morskyjezek